netdev - RE: [PATCH] [net, 83xx] ucc_geth.c: Fix upsmr setting in RMII mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <75B28D1B75754E4BAEAF634C9498EC900376A911@zil05exm11.fsl.freescale.net>
Date:	Tue, 21 Apr 2009 14:22:42 +0300
From:	"Gridish Shlomi-RM96313" <gridish@...escale.com>
To:	<hs@...x.de>, "Li Yang-R58472" <LeoLi@...escale.com>
Cc:	"Kumar Gala" <galak@...nel.crashing.org>, <netdev@...r.kernel.org>,
	<linuxppc-dev@...abs.org>
Subject: RE: [PATCH] [net, 83xx] ucc_geth.c: Fix upsmr setting in RMII mode

It is correct.
Thanks
 

> -----Original Message-----
> From: Heiko Schocher [mailto:hs@...x.de] 
> Sent: Tuesday, April 21, 2009 11:37 AM
> To: Li Yang-R58472
> Cc: Gridish Shlomi-RM96313; Kumar Gala; 
> netdev@...r.kernel.org; linuxppc-dev@...abs.org
> Subject: [PATCH] [net, 83xx] ucc_geth.c: Fix upsmr setting in 
> RMII mode
> 
> If using the UCC on a MPC8360 in RMII mode, don;t set 
> UCC_GETH_UPSMR_RPM bit in the upsmr register.
> 
> Signed-off-by: Heiko Schocher <hs@...x.de>
> ---
>  drivers/net/ucc_geth.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/ucc_geth.c b/drivers/net/ucc_geth.c 
> index d3f39e8..44f8392 100644
> --- a/drivers/net/ucc_geth.c
> +++ b/drivers/net/ucc_geth.c
> @@ -1394,7 +1394,8 @@ static int adjust_enet_interface(struct 
> ucc_geth_private *ugeth)
>  	    (ugeth->phy_interface == PHY_INTERFACE_MODE_RGMII_RXID) ||
>  	    (ugeth->phy_interface == PHY_INTERFACE_MODE_RGMII_TXID) ||
>  	    (ugeth->phy_interface == PHY_INTERFACE_MODE_RTBI)) {
> -		upsmr |= UCC_GETH_UPSMR_RPM;
> +		if (ugeth->phy_interface != PHY_INTERFACE_MODE_RMII)
> +			upsmr |= UCC_GETH_UPSMR_RPM;
>  		switch (ugeth->max_speed) {
>  		case SPEED_10:
>  			upsmr |= UCC_GETH_UPSMR_R10M;
> --
> 1.6.0.6
> 
> -- 
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html