netdev - Re: [PATCH] [net, 83xx] ucc_geth.c: Fix upsmr setting in RMII mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2a27d3730904210351s870f015gb896a4b874b3024b@mail.gmail.com>
Date:	Tue, 21 Apr 2009 18:51:11 +0800
From:	Li Yang <leoli@...escale.com>
To:	hs@...x.de
Cc:	Shlomi Gridish <gridish@...escale.com>,
	Kumar Gala <galak@...nel.crashing.org>, netdev@...r.kernel.org,
	linuxppc-dev@...abs.org
Subject: Re: [PATCH] [net, 83xx] ucc_geth.c: Fix upsmr setting in RMII mode

On Tue, Apr 21, 2009 at 4:36 PM, Heiko Schocher <hs@...x.de> wrote:
> If using the UCC on a MPC8360 in RMII mode, don;t set
> UCC_GETH_UPSMR_RPM bit in the upsmr register.
>
> Signed-off-by: Heiko Schocher <hs@...x.de>

Acked-by: Li Yang <leoli@...escale.com>

> ---
>  drivers/net/ucc_geth.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/ucc_geth.c b/drivers/net/ucc_geth.c
> index d3f39e8..44f8392 100644
> --- a/drivers/net/ucc_geth.c
> +++ b/drivers/net/ucc_geth.c
> @@ -1394,7 +1394,8 @@ static int adjust_enet_interface(struct ucc_geth_private *ugeth)
>            (ugeth->phy_interface == PHY_INTERFACE_MODE_RGMII_RXID) ||
>            (ugeth->phy_interface == PHY_INTERFACE_MODE_RGMII_TXID) ||
>            (ugeth->phy_interface == PHY_INTERFACE_MODE_RTBI)) {
> -               upsmr |= UCC_GETH_UPSMR_RPM;
> +               if (ugeth->phy_interface != PHY_INTERFACE_MODE_RMII)
> +                       upsmr |= UCC_GETH_UPSMR_RPM;
>                switch (ugeth->max_speed) {
>                case SPEED_10:
>                        upsmr |= UCC_GETH_UPSMR_R10M;
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html