netdev - Re: [PATCH] smsc911x: add fifo byteswap support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <OF0BDED475.580A7BDC-ON802575A1.003F11AE-802575A1.003F7D39@smsc.com>
Date:	Thu, 23 Apr 2009 12:33:33 +0100
From:	Steve.Glendinning@...c.com
To:	Paul Mundt <lethal@...ux-sh.org>
Cc:	davem@...emloft.net, Ian.Saturley@...c.com, iwamatsu@...auri.org,
	Magnus Damm <magnus.damm@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH] smsc911x: add fifo byteswap support

Paul Mundt <lethal@...ux-sh.org> wrote on 23/04/2009 03:09:25:

> > The best solution would be to swap the byte lanes in hardware,
> > as the device's endian swapping features only affect registers
> > (not the FIFOs).  The very latest devices in this family
> > (such as the LAN9221) can swap both independently, but this
> > driver has to also support older parts.
> > 
> > Performance will be suboptimal with this software byteswapping,
> > so I think we should also add a comment to stress that this is
> > a "last resort" workaround for broken hardware.
> > 
> > Acked-by: Steve Glendinning <steve.glendinning@...c.com>
> 
> Performance is not much of a consideration here, it's basically between
> this and no ethernet at all. On the plus side, at least not many boards
> will need this, I believe it's only 2 generations of microcontroller
> evaluation boards that suffer from this particular bit of idiocy on our
> side.

I agree, it's a handy feature to have when you're stuck with broken
hardware.  I'd like everyone who enables it to KNOW that their hardware
is broken however, so hopefully they push back on their hardware guys
to correct it in a later revision.

I'd like to avoid people getting a broken platform working using this,
then later complaining about performance!

Steve
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html