netdev - Re: [PATCH] smsc911x: add fifo byteswap support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aec7e5c30904231815x79d6f4e8g2e53de1fdeb7a73b@mail.gmail.com>
Date:	Fri, 24 Apr 2009 10:15:03 +0900
From:	Magnus Damm <magnus.damm@...il.com>
To:	Steve.Glendinning@...c.com
Cc:	davem@...emloft.net, iwamatsu@...auri.org, lethal@...ux-sh.org,
	netdev@...r.kernel.org, Ian.Saturley@...c.com
Subject: Re: [PATCH] smsc911x: add fifo byteswap support

On Thu, Apr 23, 2009 at 12:21 AM,  <Steve.Glendinning@...c.com> wrote:
> Magnus Damm <magnus.damm@...il.com> wrote on 22/04/2009 15:55:53:
>> This patch adds fifo byteswap support to the smsc911x driver.

> Performance will be suboptimal with this software byteswapping,
> so I think we should also add a comment to stress that this is
> a "last resort" workaround for broken hardware.

Good idea. How about adding the following to the header file right
before the SMSC911X_SWAP_FIFO definition:

/*
 * SMSC911X_SWAP_FIFO:
 * Enables software byte swap for fifo data. Should only be used as a
 * "last resort" in the case of big endian mode on boards with incorrectly
 * routed data bus to older devices such as LAN9118. Newer devices such as
 * LAN9221 handle this in hardware.
 */

Let me know if you want to improve the comment somehow, otherwise I'll
just update the patch and repost a V2.

Cheers,

/ magnus
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html