netdev - Re: ath5k irq warning message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090423120638.GA3168@hash.localnet>
Date:	Thu, 23 Apr 2009 08:06:38 -0400
From:	Bob Copeland <me@...copeland.com>
To:	Ben Greear <greearb@...delatech.com>
Cc:	NetDev <netdev@...r.kernel.org>
Subject: Re: ath5k irq warning message

On Wed, Apr 22, 2009 at 02:56:06PM -0700, Ben Greear wrote:
> I notice this code in the ath5k_intr method.
>
> Won't counter be -1 if you break out of this due to the 'counter-- > 0'
> clause?
>
> 	} while (ath5k_hw_is_intr_pending(ah) && counter-- > 0);

Good catch, I guess it should be --counter...

-- 
Bob Copeland %% www.bobcopeland.com

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html