netdev - Re: [oops] with FIB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <18956.37696.186135.21348@robur.slu.se>
Date:	Thu, 14 May 2009 23:55:12 +0200
From:	Robert Olsson <robert@...ur.slu.se>
To:	Stephen Hemminger <shemminger@...tta.com>
Cc:	andrei.popa@...eo.ro, Robert Olsson <Robert.Olsson@...a.slu.se>,
	NetDEV list <netdev@...r.kernel.org>
Subject: Re: [oops] with FIB_TRIE

Stephen Hemminger writes:

 > > I recompiled the kernel with FIB_TRIE and no preemption and it doesn't
 > > oops anymore.

 Thanks, for testing Andrei. I've had routing tables continusly going up
 and down for 24 hours (with no preemption) without any problem.

 > Maybe the rcu_read_lock needs to be rcu_read_lock_bh?

 Maybe,
 Need to recap this... at least for myself insert, delete and flush is 
 serialised wrt RTNL I guess this is still OK. We oops in lookup but 
 we should have preempt_disable as we're in a RCU read section. Also we 
 know quagga is constantly running delete...

 Cheers
					--ro
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html