netdev - Re: [oops] with FIB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090516212448.GC6973@linux.vnet.ibm.com>
Date:	Sat, 16 May 2009 14:24:48 -0700
From:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:	Robert Olsson <robert@...ur.slu.se>
Cc:	Stephen Hemminger <shemminger@...tta.com>, andrei.popa@...eo.ro,
	Robert Olsson <Robert.Olsson@...a.slu.se>,
	NetDEV list <netdev@...r.kernel.org>
Subject: Re: [oops] with FIB_TRIE

On Thu, May 14, 2009 at 11:55:12PM +0200, Robert Olsson wrote:
> 
> Stephen Hemminger writes:
> 
>  > > I recompiled the kernel with FIB_TRIE and no preemption and it doesn't
>  > > oops anymore.
> 
>  Thanks, for testing Andrei. I've had routing tables continusly going up
>  and down for 24 hours (with no preemption) without any problem.
> 
>  > Maybe the rcu_read_lock needs to be rcu_read_lock_bh?
> 
>  Maybe,
>  Need to recap this... at least for myself insert, delete and flush is 
>  serialised wrt RTNL I guess this is still OK. We oops in lookup but 
>  we should have preempt_disable as we're in a RCU read section. Also we 
>  know quagga is constantly running delete...

RCU read-side critical sections are not preempt_disable() if you have
built with CONFIG_PREEMPT_RCU.

							Thanx, Paul
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html