netdev - Re: [PATCH 5/5] sit: stateless autoconf for isatap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200905200057.11287.contact@saschahlusiak.de>
Date:	Wed, 20 May 2009 00:57:10 +0200
From:	Sascha Hlusiak <contact@...chahlusiak.de>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 5/5] sit: stateless autoconf for isatap

> > +	spin_lock(&ifp->lock);
> > +	for (addr = ifp->addr_list; addr; addr = addr->if_next) {
>
> You posted the same broken patch again!
>
> net/ipv6/sit.c: In function ‘ipip6_tunnel_rs_timer’:
> net/ipv6/sit.c:235: warning: passing argument 1 of ‘_spin_lock’ from
> incompatible pointer type net/ipv6/sit.c:256: warning: passing argument 1
> of ‘__raw_spin_unlock’ from incompatible pointer type
>
> This isn't rocket science. :-/
Sorry, I overlooked I had CONFIT_DEBUG_SPINLOCK unset so the above lines 
weren't even compiled.

I'm really sorry for all the noise and hope the latest resent patchset is 
finally correct. Thanks for your work.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html