netdev - Re: skbuff: Move new code into __copy_skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 23 May 2009 10:19:12 +0200
From:	Johannes Berg <johannes@...solutions.net>
To:	Herbert Xu <herbert@...dor.apana.org.au>
Cc:	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
	Paul Moore <paul.moore@...com>,
	Sujith <Sujith.Manoharan@...eros.com>,
	"John W. Linville" <linville@...driver.com>
Subject: Re: skbuff: Move new code into __copy_skb_header

On Sat, 2009-05-23 at 18:11 +1000, Herbert Xu wrote:

> skbuff: Move new __skb_clone code into __copy_skb_header
> 
> It seems that people just keep on adding stuff to __skb_clone
> instead __copy_skb_header.  This is wrong as it means your brand-new
> attributes won't always get copied as you intended.
> 
> This patch moves them to the right place, and adds a comment to
> prevent this from happening again.

Oops, thanks. But on the positive side, I'm getting rid of skb->requeue
again anyway :)

johannes


Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)