lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Sat, 23 May 2009 10:19:12 +0200
From:	Johannes Berg <>
To:	Herbert Xu <>
Cc:	"David S. Miller" <>,,
	Paul Moore <>,
	Sujith <>,
	"John W. Linville" <>
Subject: Re: skbuff: Move new code into __copy_skb_header

On Sat, 2009-05-23 at 18:11 +1000, Herbert Xu wrote:

> skbuff: Move new __skb_clone code into __copy_skb_header
> It seems that people just keep on adding stuff to __skb_clone
> instead __copy_skb_header.  This is wrong as it means your brand-new
> attributes won't always get copied as you intended.
> This patch moves them to the right place, and adds a comment to
> prevent this from happening again.

Oops, thanks. But on the positive side, I'm getting rid of skb->requeue
again anyway :)


Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)

Powered by blists - more mailing lists