netdev - Re: skbuff: Move new code into __copy_skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090525.004058.101840379.davem@davemloft.net>
Date:	Mon, 25 May 2009 00:40:58 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	herbert@...dor.apana.org.au
Cc:	netdev@...r.kernel.org, paul.moore@...com,
	Sujith.Manoharan@...eros.com, johannes@...solutions.net,
	linville@...driver.com
Subject: Re: skbuff: Move new code into __copy_skb_header

From: Herbert Xu <herbert@...dor.apana.org.au>
Date: Sat, 23 May 2009 18:11:37 +1000

> skbuff: Move new __skb_clone code into __copy_skb_header
> 
> It seems that people just keep on adding stuff to __skb_clone
> instead __copy_skb_header.  This is wrong as it means your brand-new
> attributes won't always get copied as you intended.
> 
> This patch moves them to the right place, and adds a comment to
> prevent this from happening again.
> 
> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>

Applied to net-next-2.6
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html