[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1243404615-25879-3-git-send-email-vapier@gentoo.org>
Date: Wed, 27 May 2009 02:10:12 -0400
From: Mike Frysinger <vapier@...too.org>
To: netdev@...r.kernel.org
Cc: uclinux-dist-devel@...ckfin.uclinux.org,
Sonic Zhang <sonic.zhang@...log.com>,
Mike Frysinger <vapier.adi@...il.com>,
Bryan Wu <cooloney@...nel.org>
Subject: [PATCH 2/5] netdev: bfin_mac: fix malformed UDP packet transmission when polling with KGDB
From: Sonic Zhang <sonic.zhang@...log.com>
Make sure data is really written into the registers before enabling DMA.
Otherwise, the EMAC DMA controller may transfer out a malformed packet.
This patch may also fix netperf bugs or scp bugs.
Signed-off-by: Sonic Zhang <sonic.zhang@...log.com>
Signed-off-by: Mike Frysinger <vapier.adi@...il.com>
Signed-off-by: Bryan Wu <cooloney@...nel.org>
---
drivers/net/bfin_mac.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/net/bfin_mac.c b/drivers/net/bfin_mac.c
index 1905532..626715c 100644
--- a/drivers/net/bfin_mac.c
+++ b/drivers/net/bfin_mac.c
@@ -688,6 +688,9 @@ static int bfin_mac_hard_start_xmit(struct sk_buff *skb,
}
}
+ /* Make sure data is really written into registers before enabling DMA */
+ SSYNC();
+
/* enable this packet's dma */
current_tx_ptr->desc_a.config |= DMAEN;
--
1.6.3.1
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists