netdev - [PATCH 5/5] netdev: bfin_mac: fix crash when unloading module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 27 May 2009 02:10:15 -0400
From:	Mike Frysinger <vapier@...too.org>
To:	netdev@...r.kernel.org
Cc:	uclinux-dist-devel@...ckfin.uclinux.org,
	Graf Yang <graf.yang@...log.com>
Subject: [PATCH 5/5] netdev: bfin_mac: fix crash when unloading module

From: Graf Yang <graf.yang@...log.com>

If we build the Blackfin EMAC driver as a module and then unload it at
runtime, it would cause a crash:
root:/> rmmod bfin_mac
Hardware Trace:
   0 Target : <0x00004624> { _dump_bfin_trace_buffer + 0x0 }
     Source : <0x000a57b2> { _mdiobus_unregister + 0x42 } CALL pcrel
   1 Target : <0x000a57b2> { _mdiobus_unregister + 0x42 }
     Source : <0x000a577c> { _mdiobus_unregister + 0xc } IF !CC JUMP
   2 Target : <0x000a5770> { _mdiobus_unregister + 0x0 }
     Source : <0x037a4c9e> { :bfin_mac:_cleanup_module + 0x4a } CALL (P2)
   3 Target : <0x037a4c80> { :bfin_mac:_cleanup_module + 0x2c }
     Source : <0x000a0a2e> { _platform_drv_remove + 0xe } JUMP (P1)
   4 Target : <0x000a0a20> { _platform_drv_remove + 0x0 }
     Source : <0x0009fcc0> { ___device_release_driver + 0x50 } CALL (P2)
   ....

URL: http://blackfin.uclinux.org/gf/tracker/4885
Signed-off-by: Graf Yang <graf.yang@...log.com>
Signed-off-by: Mike Frysinger <vapier@...too.org>
---
 drivers/net/bfin_mac.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/net/bfin_mac.c b/drivers/net/bfin_mac.c
index 7f8ea0f..e764f8c 100644
--- a/drivers/net/bfin_mac.c
+++ b/drivers/net/bfin_mac.c
@@ -1074,8 +1074,7 @@ static int __devexit bfin_mac_remove(struct platform_device *pdev)
 
 	platform_set_drvdata(pdev, NULL);
 
-	mdiobus_unregister(lp->mii_bus);
-	mdiobus_free(lp->mii_bus);
+	lp->mii_bus->priv = NULL;
 
 	unregister_netdev(ndev);
 
-- 
1.6.3.1

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html