netdev - Re: [PATCH 2/5] netdev: bfin_mac: fix malformed UDP packet transmission when polling with KGDB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 29 May 2009 02:04:05 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	vapier@...too.org
Cc:	netdev@...r.kernel.org, uclinux-dist-devel@...ckfin.uclinux.org,
	sonic.zhang@...log.com, vapier.adi@...il.com, cooloney@...nel.org
Subject: Re: [PATCH 2/5] netdev: bfin_mac: fix malformed UDP packet
 transmission when polling with KGDB

From: Mike Frysinger <vapier@...too.org>
Date: Wed, 27 May 2009 02:10:12 -0400

> From: Sonic Zhang <sonic.zhang@...log.com>
> 
> Make sure data is really written into the registers before enabling DMA.
> Otherwise, the EMAC DMA controller may transfer out a malformed packet.
> This patch may also fix netperf bugs or scp bugs.
> 
> Signed-off-by: Sonic Zhang <sonic.zhang@...log.com>
> Signed-off-by: Mike Frysinger <vapier.adi@...il.com>
> Signed-off-by: Bryan Wu <cooloney@...nel.org>

Instead of using this incredibly non-portable blackfin specific SSYNC
thing, why not read back a register from the device to ensure the
register writes hit the chip just like other drivers do?

If that doesn't work, enhance your commit message to describe (in
detail) why SSYNC is the only way to make this work properly.

I'm not applying this as-is.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html