netdev - Re: [PATCH 3/5] netdev: bfin_mac: fix performance issue found by netperf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090529.020554.107005632.davem@davemloft.net>
Date:	Fri, 29 May 2009 02:05:54 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	vapier@...too.org
Cc:	netdev@...r.kernel.org, uclinux-dist-devel@...ckfin.uclinux.org,
	michael.hennerich@...log.com, cooloney@...nel.org
Subject: Re: [PATCH 3/5] netdev: bfin_mac: fix performance issue found by
 netperf

From: Mike Frysinger <vapier@...too.org>
Date: Wed, 27 May 2009 02:10:13 -0400

> @@ -606,86 +606,28 @@ static int bfin_mac_hard_start_xmit(struct sk_buff *skb,
>  				struct net_device *dev)
>  {
>  	u16 *data;
> -
> +	u32 data_align = (u32)(skb->data) & 0x3;

A pointer is not castable directly to a u32 everywhere.  It can be
64-bits and in which case GCC will warn here.

I know this is a blackfin specific driver, but please write portable
code.

Use "unsigned long" or similar.

I'm not applying this as it is now.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html