[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <200906022337.33799.rusty@rustcorp.com.au>
Date: Tue, 2 Jun 2009 23:37:33 +0930
From: Rusty Russell <rusty@...tcorp.com.au>
To: Mark McLoughlin <markmc@...hat.com>
Cc: netdev@...r.kernel.org, virtualization@...ts.linux-foundation.org
Subject: Re: [PATCH 3/4] virtio_net: don't free buffers in xmit ring
On Tue, 2 Jun 2009 09:11:42 pm Mark McLoughlin wrote:
> On Tue, 2009-06-02 at 09:13 +0100, Mark McLoughlin wrote:
> > I think skb_orphan() is enough to prevent this, is it?
>
> Oops, I meant:
>
> I don't think skb_orphan() is enough to prevent this, is it?
Yes, point taken. No, it's not. We could add nf_reset here too, which would
be perfectly sane.
I'm tempted to avoid the question marks hanging over generic skb_orphan for
now, and just do skb_orphan & nf_reset at the head of our driver.
Then look at making skb_orphan do nf_reset. It makes sense, but I'd have to
audit all the callers.
Thanks.
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists