netdev - Re: [PATCH 03/10] net: add IEEE 802.15.4 socket family implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bc64b4640906040710p5c7c941fi3341599bc3157b79@mail.gmail.com>
Date:	Thu, 4 Jun 2009 18:10:41 +0400
From:	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>
To:	"John W. Linville" <linville@...driver.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	linux-wireless@...r.kernel.org, slapin@...fans.org,
	maxim.osipov@...mens.com, dmitry.baryshkov@...mens.com,
	oliver.fendt@...mens.com
Subject: Re: [PATCH 03/10] net: add IEEE 802.15.4 socket family implementation

2009/6/4 John W. Linville <linville@...driver.com>:
> On Thu, Jun 04, 2009 at 03:16:34PM +0400, Dmitry Eremin-Solenikov wrote:
>> On Wed, Jun 03, 2009 at 05:32:14PM -0700, Andrew Morton wrote:
>> > On Mon,  1 Jun 2009 18:54:44 +0400
>> > Dmitry Eremin-Solenikov <dbaryshkov@...il.com> wrote:
>
>> > > + switch (addr->addr_type) {
>> > > + case IEEE802154_ADDR_LONG:
>> > > +         rtnl_lock();
>> > > +         dev = dev_getbyhwaddr(net, ARPHRD_IEEE802154, addr->hwaddr);
>> > > +         if (dev)
>> > > +                 dev_hold(dev);
>> > > +         rtnl_unlock();
>> > > +         break;
>> > > + case IEEE802154_ADDR_SHORT:
>> > > +         if (addr->pan_id != 0xffff && addr->short_addr != IEEE802154_ADDR_UNDEF && addr->short_addr != 0xffff) {
>> > > +                 struct net_device *tmp;
>> > > +
>> > > +                 rtnl_lock();
>> > > +
>> > > +                 for_each_netdev(net, tmp) {
>> > > +                         if (tmp->type == ARPHRD_IEEE802154) {
>> > > +                                 if (IEEE802154_MLME_OPS(tmp)->get_pan_id(tmp) == addr->pan_id
>> > > +                                   && IEEE802154_MLME_OPS(tmp)->get_short_addr(tmp) == addr->short_addr) {
>> >
>> > You must use very wide xterms :(
>>
>> ~120 chars in width :)  We prefer to have a single code line split between
>> several screen lines, rather than split it manually in some weird places
>> just to justify width of 80 chars.
>
> Hopefully you realize that many find this difficult to read -- I just
> can't spread my eyes far enough to comprehend the lines.
>
> 80 chars is not a hard limit, but it is a good goal.  120 is too wide.

We do try to fit the lines into 80 chars, but when that seems logical.
I strongly dislike breaking comparations between lines.

-- 
With best wishes
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html