netdev - Re: [PATCH 03/10] net: add IEEE 802.15.4 socket family implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1244124936.22576.73.camel@johannes.local>
Date:	Thu, 04 Jun 2009 16:15:36 +0200
From:	Johannes Berg <johannes@...solutions.net>
To:	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>
Cc:	"John W. Linville" <linville@...driver.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	linux-wireless@...r.kernel.org, slapin@...fans.org,
	maxim.osipov@...mens.com, dmitry.baryshkov@...mens.com,
	oliver.fendt@...mens.com
Subject: Re: [PATCH 03/10] net: add IEEE 802.15.4 socket family
 implementation

On Thu, 2009-06-04 at 18:10 +0400, Dmitry Eremin-Solenikov wrote:

> We do try to fit the lines into 80 chars, but when that seems logical.
> I strongly dislike breaking comparations between lines.

There are a whole bunch of improvements possible at this particular
spot:

switch (X) {
case Y:
	if (A) {
		...
	}
	break;
...
}

can be written as

switch (X) {
case Y:
	if (!A)
		break;
	...
	break;
}


and 

for (...) {
	if (A) {
		...
		break;
	}
}

can be written as

for (...) {
	if (!A)
		continue;
	...
	break;
}

etc.

Show some creativity!

johannes

Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)