netdev - Re: virtio_net: Set correct gso->hdr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090605065312.GA7590@gondor.apana.org.au>
Date:	Fri, 5 Jun 2009 16:53:12 +1000
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Rusty Russell <rusty@...tcorp.com.au>
Cc:	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: virtio_net: Set correct gso->hdr_len

On Fri, Jun 05, 2009 at 04:20:02PM +0930, Rusty Russell wrote:
>
> Right, understood now.  It really is just a hint as to how much to copy.  It 
> wasn't supposed to be that, as virtio_net.h:
> 
> 	__u16 hdr_len;		/* Ethernet + IP + tcp/udp hdrs */
> 	__u16 gso_size;		/* Bytes to append to hdr_len per frame */
> 
> The host was supposed to be able to de-gso packets together relying on 
> hdr_len.  But that's silly: it can't do TSO without knowing about sequence 
> numbers at least, and UFO without ip fragmentation offsets.  ie. it might as 
> well calc hdr_len itself.

Well I always thought hdr_len was meant to represent what should
be in the linear header :)

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html