[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4A291DE5.9040802@trash.net>
Date: Fri, 05 Jun 2009 15:30:13 +0200
From: Patrick McHardy <kaber@...sh.net>
To: Jan Engelhardt <jengelh@...ozas.de>
CC: Evgeniy Polyakov <zbr@...emap.net>, netdev@...r.kernel.org,
David Miller <davem@...emloft.net>,
"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
Netfilter Development Mailinglist
<netfilter-devel@...r.kernel.org>
Subject: Re: Passive OS fingerprint xtables match.
Jan Engelhardt wrote:
> On Friday 2009-06-05 13:54, Patrick McHardy wrote:
>
>>> +
>>> + if (optsize > sizeof(opts))
>>> + optsize = sizeof(opts);
>>>
>> How can this happen? The doff field can only represent up to 40
>> bytes of option length.
>>
>
> Forged packets?
How would that increase the size of the doff field? :)
>>> + printk(KERN_INFO "Started passive OS fingerprint matching module.\n");
>>>
>> Please no messages on successful module load. Or at least
>> not when statically built, but preferrably not at all.
>>
>
> By that logic should not the messages-on-load for netfilter be removed? ;-)
>
I wouldn't care, but there's a difference between the main module printing a
message and extensions printing a message.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists