[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4A2F49DB.20207@us.ibm.com>
Date: Tue, 09 Jun 2009 22:51:23 -0700
From: Sridhar Samudrala <sri@...ibm.com>
To: Herbert Xu <herbert@...dor.apana.org.au>
CC: davem@...emloft.net, netdev@...r.kernel.org, kvm@...r.kernel.org,
rusty@...tcorp.com.au
Subject: Re: [PATCH net-next 2/4] udp: Handle large UFO packets from untrusted
sources
Herbert Xu wrote:
> On Mon, Jun 08, 2009 at 10:04:47AM -0700, Sridhar Samudrala wrote:
>
>> OK. Can we use skb_segment() to do IP fragmentation of UDP packets?
>>
>
> It should be able to.
>
Unfortunately, this doesn't work for UDP without any changes.
skb_segment() currently adds transport header to
each segmented skb. But when we are using IP fragmentation, only the
first fragment should include the UDP
header.
We either need to fix skb_segment() to handle IP fragmentation or write
a new skb_fragment(). I will look into
this when i get some time.
Thanks
Sridhar
>
>> The function itself looks protocol independent and if it is simply
>> splitting large skb into a list of mtu sized skb's, can we fixup the
>> ip header differently for UDP packets(id and frag_off) in inet_gso_segment
>> and ipv6_gso_segment?
>>
>
> Yes that's the idea.
>
> Cheers,
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists