netdev - Re: [PATCH net-next 2/4] udp: Handle large UFO packets from untrusted sources

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090610091757.GA19155@gondor.apana.org.au>
Date:	Wed, 10 Jun 2009 19:17:57 +1000
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Sridhar Samudrala <sri@...ibm.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org, kvm@...r.kernel.org,
	rusty@...tcorp.com.au
Subject: Re: [PATCH net-next 2/4] udp: Handle large UFO packets from
	untrusted sources

On Tue, Jun 09, 2009 at 10:51:23PM -0700, Sridhar Samudrala wrote:
>
> Unfortunately, this doesn't work for UDP without any changes.  
> skb_segment() currently adds transport header to
> each segmented skb. But when we are using IP fragmentation, only the  
> first fragment should include the UDP
> header.
> We either need to fix skb_segment() to handle IP fragmentation or write  
> a new skb_fragment(). I will look into
> this when i get some time.

Couldn't you get around this by setting skb->transport_header to
skb->network_header before getting into skb_segment?

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html