netdev - Re: rfkill regression in net-next-2.6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4A364ABB.6040704@hartkopp.net>
Date:	Mon, 15 Jun 2009 15:20:59 +0200
From:	Oliver Hartkopp <socketcan@...tkopp.net>
To:	Johannes Berg <johannes@...solutions.net>
CC:	"John W. Linville" <linville@...driver.com>,
	Marcel Holtmann <marcel@...tmann.org>,
	David Miller <davem@...emloft.net>,
	linux-wireless@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: rfkill regression in net-next-2.6

Johannes Berg wrote:
> On Mon, 2009-06-15 at 08:04 -0400, John W. Linville wrote:
>> On Sun, Jun 14, 2009 at 10:54:17AM +0200, Oliver Hartkopp wrote:
>>
>>> Any idea what changed in net-next-2.6 that could produce this behaviour?
>> The rfkill subsystem rewrite would seem suspect... :-)
> 
> Maybe this fixes it?

Yes, that made it!

I booted with the RFKILL switch ON and OFF and the system and the LEDs are
working as one would expect it.

Thanks Johannes.

Tested-by: Oliver Hartkopp <oliver@...tkopp.net>


> 
> johannes
> 
> --- wireless-testing.orig/drivers/platform/x86/dell-laptop.c	2009-06-15 14:23:25.000000000 +0200
> +++ wireless-testing/drivers/platform/x86/dell-laptop.c	2009-06-15 14:23:35.000000000 +0200
> @@ -177,7 +177,7 @@ dell_send_request(struct calling_interfa
>  static int dell_rfkill_set(void *data, bool blocked)
>  {
>  	struct calling_interface_buffer buffer;
> -	int disable = blocked ? 0 : 1;
> +	int disable = blocked ? 1 : 0;
>  	unsigned long radio = (unsigned long)data;
>  
>  	memset(&buffer, 0, sizeof(struct calling_interface_buffer));
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html