netdev - Re: net: fix network drivers ndo_start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A376ABC.2020303@trash.net>
Date:	Tue, 16 Jun 2009 11:49:48 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	Jarek Poplawski <jarkao2@...il.com>
CC:	"David S. Miller" <davem@...emloft.net>,
	Linux Netdev List <netdev@...r.kernel.org>, perex@...ex.cz
Subject: Re: net: fix network drivers ndo_start_xmit() return values

Jarek Poplawski wrote:
> On Tue, Jun 16, 2009 at 11:31:17AM +0200, Patrick McHardy wrote:
>> Jarek Poplawski wrote:
>>> On Tue, Jun 16, 2009 at 06:16:03AM +0000, Jarek Poplawski wrote:
>>>   
>>>> On 15-06-2009 19:00, Patrick McHardy wrote:
>>>>     
>>>>> This patch contains the final driver ndo_start_xmit() return
>>>>> value fixups. I'm pretty sure I got them all ...
>>>>>       
>>> ...You should probably revisit wireless/zd1201.c (return 0) btw.
>> Whats wrong with that?
> 
> I thought you wanted to replace it with NETDEV_TX_OK, but now I see
> you leave both variants in the last patch, so I'm not sure...

I wanted to do that in a seperate patch at the end of the merge
window to avoid causing too much clashes with this (and catch
any new drivers).
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html