netdev - Re: [PATCH net-next-2.6] udp: remove unused union in udp_skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <eb3ff54b0906160254q4ad0e852k611d7f2772afc185@mail.gmail.com>
Date:	Tue, 16 Jun 2009 12:54:10 +0300
From:	Rami Rosen <ramirose@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next-2.6] udp: remove unused union in udp_skb_cb.

Hi,
Sorry, I forgot that besides UDP_SKB_CB() also the
IPSKB() macro can access the cb.

>The layer above UDP packet processing used
> IPSKB() and the ipv6 variant (I forget what it's called)

BTW, it is IP6CB() in IPV6

Regards,
Rami Rosen

On Tue, Jun 16, 2009 at 12:40 PM, David Miller<davem@...emloft.net> wrote:
> From: Rami Rosen <ramirose@...il.com>
> Date: Tue, 16 Jun 2009 11:50:11 +0300
>
>> This cleanup patch removes an unused union (header) in udp_skb_cb.
>> (include/net/udp.h)
>
> It is used Rami.  The layer above UDP packet processing used
> IPSKB() and the ipv6 variant (I forget what it's called) so
> we have to take care not to write over that layer's recorded
> values in the skb->cb[]
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html