[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20090617.043534.259824726.davem@davemloft.net>
Date: Wed, 17 Jun 2009 04:35:34 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: mingo@...e.hu
Cc: eric.dumazet@...il.com, tglx@...utronix.de,
torvalds@...ux-foundation.org, akpm@...ux-foundation.org,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
kaber@...sh.net
Subject: Re: [bug] __nf_ct_refresh_acct(): WARNING: at lib/list_debug.c:30
__list_add+0x7d/0xad()
From: Ingo Molnar <mingo@...e.hu>
Date: Wed, 17 Jun 2009 13:08:03 +0200
>
> * Eric Dumazet <eric.dumazet@...il.com> wrote:
>
>> IPS_CONFIRMED_BIT is set under nf_conntrack_lock (in __nf_conntrack_confirm()),
>> we probably want to add a synchronisation under ct->lock as well,
>> or __nf_ct_refresh_acct() could set ct->timeout.expires to extra_jiffies,
>> while a different cpu could confirm the conntrack.
>>
>> Following patch as RFC
>
> A quick test suggests that it seems to works here - thanks Eric!
Patrick, please take a quick look at Eric's fix. I'd like to
apply it quickly if it looks good to you.
Thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists