netdev - Re: [PATCH] genetlink: make netns aware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1245274620.31588.49.camel@johannes.local>
Date:	Wed, 17 Jun 2009 23:37:00 +0200
From:	Johannes Berg <johannes@...solutions.net>
To:	"Eric W. Biederman" <ebiederm@...ssion.com>
Cc:	Netdev <netdev@...r.kernel.org>, Thomas Graf <tgraf@...g.ch>,
	"Eric W. Biederman" <ebiederm@...stanetworks.com>,
	Alexey Dobriyan <adobriyan@...il.com>
Subject: Re: [PATCH] genetlink: make netns aware

On Wed, 2009-06-17 at 14:19 -0700, Eric W. Biederman wrote:

> Nothing at first glance looks wrong.

Will review locking :) Not sure I hold enough locks at the correct
places here.

> Most of these genetlink things are network related so making it
> network namespace aware makes sense.

Well, some are non-network, and some are network, like nl80211. My goal
is this patch:
http://johannes.sipsolutions.net/patches/kernel/all/LATEST/016-cfg80211-netns.patch

It already kinda works, but has bugs like not going back to init_net if
the ns a wiphy is in exits, and some more like that.

> My impression had been that genetlink was mostly not network related
> and I would have to solve the other hard problem of how to filter
> sockets based on other namespaces.  I guess that can be delayed for
> a while longer.

Ah, well, I was thinking that the generic netlink family code would have
to take care of that.

johannes

Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)