netdev - Re: [PATCH] genetlink: make netns aware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m1hbyev8d1.fsf@fess.ebiederm.org>
Date:	Wed, 17 Jun 2009 14:49:30 -0700
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	Johannes Berg <johannes@...solutions.net>
Cc:	Netdev <netdev@...r.kernel.org>, Thomas Graf <tgraf@...g.ch>,
	"Eric W. Biederman" <ebiederm@...stanetworks.com>,
	Alexey Dobriyan <adobriyan@...il.com>
Subject: Re: [PATCH] genetlink: make netns aware

Johannes Berg <johannes@...solutions.net> writes:

> On Wed, 2009-06-17 at 14:19 -0700, Eric W. Biederman wrote:
>
>> Nothing at first glance looks wrong.
>
> Will review locking :) Not sure I hold enough locks at the correct
> places here.

grr. At first glance NOTHING looks wrong.
I have a bad habit of skipping the most important word in my sentences
sometimes.

>> Most of these genetlink things are network related so making it
>> network namespace aware makes sense.
>
> Well, some are non-network, and some are network, like nl80211. My goal
> is this patch:
> http://johannes.sipsolutions.net/patches/kernel/all/LATEST/016-cfg80211-netns.patch
>
> It already kinda works, but has bugs like not going back to init_net if
> the ns a wiphy is in exits, and some more like that.
>
>> My impression had been that genetlink was mostly not network related
>> and I would have to solve the other hard problem of how to filter
>> sockets based on other namespaces.  I guess that can be delayed for
>> a while longer.
>
> Ah, well, I was thinking that the generic netlink family code would have
> to take care of that.

Probably.  As even genetlink has those kinds of users.  The kernel
receive path is easy now.  Yeah for synchronous processing. It is
which socket do you transmit on that is interesting.

Eric
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html