netdev - Re: [PATCH v2] ftrace: change the export format of trace_kfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.0906180847540.6890@gandalf.stny.rr.com>
Date:	Thu, 18 Jun 2009 08:51:12 -0400 (EDT)
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Neil Horman <nhorman@...driver.com>
cc:	Xiao Guangrong <xiaoguangrong@...fujitsu.com>,
	Ingo Molnar <mingo@...e.hu>,
	Frederic Weisbecker <fweisbec@...il.com>,
	LKML <linux-kernel@...r.kernel.org>, netdev@...r.kernel.org,
	David Miller <davem@...emloft.net>
Subject: Re: [PATCH v2] ftrace: change the export format of
 trace_kfree_skb()


On Thu, 18 Jun 2009, Neil Horman wrote:
> > 
> > diff --git a/include/trace/events/skb.h b/include/trace/events/skb.h
> > index 1e8fabb..2496060 100644
> > --- a/include/trace/events/skb.h
> > +++ b/include/trace/events/skb.h
> > @@ -7,6 +7,71 @@
> >  #undef TRACE_SYSTEM
> >  #define TRACE_SYSTEM skb
> >  
> > +#define protocol_name(protocol) { protocol, #protocol }
> > +#define show_protocol_name(val)					\
> > +	__print_symbolic(val,					\
> 
> Don't you need to include ftrace.h to pull in the __print_symbolic definition?
> Or is that always guaranteed to be included from tracepoint.h?

Its use is in one of the fields of TRACE_EVENT that are only used by 
define_trace.h. All other users will ignore it.

#define TRACE_EVENT(name, proto, args, struct, assign, print)	\
	DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))

Only name, proto, args is used. The define_trace.h will include 
trace/ftrace.h and that will use the struct, assign and print args.

So the answer is "no" ;-)

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html