netdev - Re: [PATCH] Revert "ipv4: arp announce, arp_proxy and windows ip conflict verification"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090630.201016.203484460.davem@davemloft.net>
Date:	Tue, 30 Jun 2009 20:10:16 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	ebiederm@...ssion.com
Cc:	netdev@...r.kernel.org, denys@...p.net.lb, stable@...nel.org
Subject: Re: [PATCH] Revert "ipv4: arp announce, arp_proxy and windows ip
 conflict verification"

From: ebiederm@...ssion.com (Eric W. Biederman)
Date: Tue, 30 Jun 2009 19:27:17 -0700

> This reverts commit 73ce7b01b4496a5fbf9caf63033c874be692333f.
> 
> After discovering that we don't listen to gratuitious arps in 2.6.30
> I tracked the failure down to this commit.
> 
> The patch makes absolutely no sense.  RFC2131 RFC3927 and RFC5227.
> are all in agreement that an arp request with sip == 0 should be used
> for the probe (to prevent learning) and an arp request with sip == tip
> should be used for the gratitous announcement that people can learn
> from.
> 
> It appears the author of the broken patch got those two cases confused
> and modified the code to drop all gratuitous arp traffic.  Ouch!
> 
> Cc: stable@...nel.org
> Signed-off-by: Eric W. Biederman <ebiederm@...stanetworks.com>

Applied and queued up for -stable, thanks Eric.

To be honest I didn't want to apply that patch, but it seemed
to match up with the RFC in question so I figured I had no
arguments against it :)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html