netdev - Re: [RFC] arp announce, arp_proxy and windows ip conflict verification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200907010154.27457.denys@visp.net.lb>
Date:	Wed, 1 Jul 2009 01:54:27 +0300
From:	Denys Fedoryschenko <denys@...p.net.lb>
To:	"Eric W. Biederman" <ebiederm@...ssion.com>
Cc:	netdev@...r.kernel.org, David Miller <davem@...emloft.net>
Subject: Re: [RFC] arp announce, arp_proxy and windows ip conflict verification

On Wednesday 01 July 2009 01:55:59 Eric W. Biederman wrote:
>
> I have a problem with this patch.  It stops gratuitous arps updating
> my arp cache.  I'm still trying to figure out what the correct behaviour
> should be.
>
> Perhaps making the goto out; become if (sip == 0) goto out;
Yes, you are right. 

Proposing 3 simple patches against git next-next-2.6 . As attaches (sorry, 
kmail). All of them equal, but since i am amateur in programming, i dont know 
how it is should be done "nice way".

If you want to test it - do it carefully. I didn't did runtime tests yet, but 
they are compile tested. (But they are trivial).

If someone can review and tell if any of them ok, i will submit it with proper 
tags and etc.

View attachment "patch1.diff" of type "text/x-diff" (694 bytes)

View attachment "patch2.diff" of type "text/x-diff" (726 bytes)

View attachment "patch3.diff" of type "text/x-diff" (422 bytes)