[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20090703.191200.136944764.davem@davemloft.net>
Date: Fri, 03 Jul 2009 19:12:00 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: jeffrey.t.kirsher@...el.com
Cc: netdev@...r.kernel.org, gospo@...hat.com,
donald.c.skidmore@...el.com
Subject: Re: [net-2.6 PATCH 1/4] ixgbe: fix issues with failing to detect
insert of unsupported module
From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Thu, 02 Jul 2009 15:50:12 -0700
> From: Don Skidmore <donald.c.skidmore@...el.com>
>
> Several small fixes around negative test case of the insertion of a
> IXGBE_ERR_NOT_SUPPORTED module.
>
> - mdio45_probe call was always failing due to mdio.prtad not being
> set. The function set to mdio.mdio_read was still working as we just
> happen to always be at prtad == 0. This will allow us to set the phy_id
> and phy.type correctly now.
>
> - There was timing issue with i2c calls when initiated from a tasklet.
> A small delay was added to allow the electrical oscillation to calm down.
>
> - Logic change in ixgbe_sfp_task that allows NOT_SUPPORTED condition
> to be recognized.
>
> Signed-off-by: Don Skidmore <donald.c.skidmore@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists