[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20090703.191211.185827358.davem@davemloft.net>
Date: Fri, 03 Jul 2009 19:12:11 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: jeffrey.t.kirsher@...el.com
Cc: netdev@...r.kernel.org, gospo@...hat.com,
peter.p.waskiewicz.jr@...el.com, donald.c.skidmore@...el.com
Subject: Re: [net-2.6 PATCH 2/4] ixgbe: fix regression on some 82598
adapters
From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Thu, 02 Jul 2009 15:50:31 -0700
> From: Don Skidmore <donald.c.skidmore@...el.com>
>
> The change to check the SFP+ module again on open() was
> causing the XFP (non-SFP+) adapters to be rejected. We
> only want to try and re-identify the SFP+ module if the
> original probe found that this device was an SFP+ device.
> So for this code path (driver loaded with SFP module, module
> inserted, ifconfig up of the device) the type will be
> ixgbe_phy_unknown for an unidentified SFP+ module. So we
> only check if that is the case.
>
> This problem also shows up on Copper devices.
>
> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com>
> Signed-off-by: Don Skidmore <donald.c.skidmore@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists