netdev - Re: [net-2.6 PATCH 3/4] ixgbe: fix inconsistent SFP/SFP+ failure results.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090703.191219.159352502.davem@davemloft.net>
Date:	Fri, 03 Jul 2009 19:12:19 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jeffrey.t.kirsher@...el.com
Cc:	netdev@...r.kernel.org, gospo@...hat.com,
	donald.c.skidmore@...el.com
Subject: Re: [net-2.6 PATCH 3/4] ixgbe: fix inconsistent SFP/SFP+ failure
 results.

From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Thu, 02 Jul 2009 15:50:52 -0700

> From: Don Skidmore <donald.c.skidmore@...el.com>
> 
> Currently if we loaded the driver, insert an unsupported module, and then
> attempt to "ifconfig up" the device it will be brought down but the netdev
> would not be unregistered. This behavior is different than all other
> code paths. This patch corrects that by down'ing the device and then
> scheduling the sfp_config_module_task tasklet. The tasklet will detect
> this condition (like it does with other code paths) and do the
> unregister_netdev().
> 
> I also removed the log message as this condition (an unsupported SFP+
> module) will be logged in sfp_config_module_task.
> 
> Signed-off-by: Don Skidmore <donald.c.skidmore@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html