netdev - Re: [PATCH] atlx: duplicate testing of MCAST flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3400f2f60907121704s105ba16bqebcdb75bc855888e@mail.gmail.com>
Date:	Sun, 12 Jul 2009 19:04:20 -0500
From:	"J. K. Cliburn" <jcliburn@...il.com>
To:	Roel Kluin <roel.kluin@...il.com>
Cc:	atl1-devel@...ts.sourceforge.net,
	Andrew Morton <akpm@...ux-foundation.org>,
	netdev <netdev@...r.kernel.org>,
	David Miller <davem@...emloft.net>
Subject: Re: [PATCH] atlx: duplicate testing of MCAST flag

On Sun, Jul 12, 2009 at 6:12 PM, Roel Kluin<roel.kluin@...il.com> wrote:
> Fix duplicate testing of MCAST flag
>
> Signed-off-by: Roel Kluin <roel.kluin@...il.com>
> ---
> I think the first should be UCAST, correct?
>
> diff --git a/drivers/net/atlx/atl2.c b/drivers/net/atlx/atl2.c
> index c734b19..204db96 100644
> --- a/drivers/net/atlx/atl2.c
> +++ b/drivers/net/atlx/atl2.c
> @@ -2071,7 +2071,7 @@ static int atl2_set_wol(struct net_device *netdev, struct ethtool_wolinfo *wol)
>        if (wol->wolopts & (WAKE_ARP | WAKE_MAGICSECURE))
>                return -EOPNOTSUPP;
>
> -       if (wol->wolopts & (WAKE_MCAST|WAKE_BCAST|WAKE_MCAST))
> +       if (wol->wolopts & (WAKE_UCAST | WAKE_BCAST | WAKE_MCAST))
>                return -EOPNOTSUPP;
>
>        /* these settings will always override what we currently have */
>

Acked-by: Jay Cliburn <jcliburn@...il.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html