| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <392fb48f0907121706n2ebd0751l110b109de1a18ce8@mail.gmail.com> Date: Mon, 13 Jul 2009 09:06:25 +0900 From: Mike McCormack <mikem@...g3k.org> To: Stephen Hemminger <shemminger@...ux-foundation.org> Cc: netdev@...r.kernel.org Subject: Re: [PATCH] sky2: Avoid transmitting during sky2_restart() 2009/7/13 Stephen Hemminger <shemminger@...ux-foundation.org>: > On Sun, 12 Jul 2009 14:39:29 +0900 > Mike McCormack <mikem@...g3k.org> wrote: > >> Hi Stephen, >> >> "ifconfig eth1 up; pktget eth1" will crashed my machine within 10 >> seconds. (eth1 is sky2) >> It appears that sky2_tx_timeout causes a restart, and packets in the >> tx queue are free'd twice (once in sky2_status_intr and once in >> sky2_down). >> Furthermore, if sky2_xmit_frame is called during sky2_restart, bad >> things will happen. >> >> This patch fixes both problems and was tested on top of my previous >> sky2_down fix. >> >> thanks, >> >> Mike > > This should be fixed by managing the queue properly, not > by using a state flag. I will correct the problem. I think some kind of state needs to be used, as sky2_tx_complete() will wake the tx queue if you use netif_tx_stop_queue() and netif_tx_lock() is used elsewhere, and is not recursive. I am happy to change the patch if you have a suggestion on which function to use. thanks, Mike -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists