netdev - Re: [PATCH] gre: copy ToS/DiffServ bits to outer IP header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090713.092725.90035484.davem@davemloft.net>
Date:	Mon, 13 Jul 2009 09:27:25 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	shemminger@...tta.com
Cc:	aj@...n.ch, netdev@...r.kernel.org, kuznet@....inr.ac.ru,
	kaber@...sh.net
Subject: Re: [PATCH] gre: copy ToS/DiffServ bits to outer IP header

From: Stephen Hemminger <shemminger@...tta.com>
Date: Mon, 13 Jul 2009 09:07:43 -0700

> On Mon, 13 Jul 2009 18:01:42 +0200
> Andreas Jaggi <aj@...n.ch> wrote:
> 
>> On Mon, Jul 13, 2009 at 08:33:03AM -0700, Stephen Hemminger wrote:
>> > Why make it an option? Sounds like it should always be on.
>> 
>> In some scenarios people might want to set the ToS value for all
>> GRE tunnel packets to a fixed value (cf. ip tunnel tos option).
> 
> Having more options, does not help users.  Why not just do that
> with iptables or classifiers?

I think we should behave however our other IP tunnels behave by
default in this situation.

But regardless, always there is the argument that changing default
behavior is surprising and will bite someone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html