netdev - Re: [PATCH] gre: copy ToS/DiffServ bits to outer IP header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090713.104433.244099298.davem@davemloft.net>
Date:	Mon, 13 Jul 2009 10:44:33 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	aj@...n.ch
Cc:	netdev@...r.kernel.org, kuznet@....inr.ac.ru, kaber@...sh.net
Subject: Re: [PATCH] gre: copy ToS/DiffServ bits to outer IP header

From: Andreas Jaggi <aj@...n.ch>
Date: Mon, 13 Jul 2009 15:32:25 +0200

> @@ -24,6 +24,7 @@
>  #define GRE_REC		__constant_htons(0x0700)
>  #define GRE_FLAGS	__constant_htons(0x00F8)
>  #define GRE_VERSION	__constant_htons(0x0007)
> +#define GRE_COPY_TOS	__constant_htons(0x0008)
>  
>  struct ip_tunnel_parm
>  {

This seems dangerious, and unnecessary.

If some future RFC defines this flag, we'll have to change
this and add ugly compat code to keep older tools working.

Why not just create a new IFLA_GRE_* attribute to pass in
flags like this that purely are private to the GRE Linux
tunnel driver and have nothing to do with values defined
by GRE tunnel headers at all?

I'm definitely not applying this as-is.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html