netdev - Re: [PATCH] NET: Fix locking issues in PPP, 6pack, mkiss and strip line disciplines.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090712.210730.170014470.davem@davemloft.net>
Date:	Sun, 12 Jul 2009 21:07:30 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	alan@...rguk.ukuu.org.uk
Cc:	ralf@...ux-mips.org, netdev@...r.kernel.org,
	guido@...ntalancia.com, paulus@...ba.org,
	linux-hams@...r.kernel.org, hans@...ac.ele.tue.nl
Subject: Re: [PATCH] NET: Fix locking issues in PPP, 6pack, mkiss and strip
 line disciplines.

From: Alan Cox <alan@...rguk.ukuu.org.uk>
Date: Sun, 12 Jul 2009 23:48:54 +0100

>> The issue was, that the locking code in mkiss was assuming it was only
>> ever being called in process or bh context.  Fixed by converting the
>> involved locking code to use irq-safe locks.
> 
> Which historically of course was correct until the networking layer
> changed behaviour some years ago.

Networking layer?  Surely you mean the TTY layer or USB because I
don't see anything networking in his traces :-)

> These look good to me.

Thanks for reviewing, I'll apply his patch.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html