lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 13 Jul 2009 09:19:28 +0100 From: Alan Cox <alan@...rguk.ukuu.org.uk> To: David Miller <davem@...emloft.net> Cc: ralf@...ux-mips.org, netdev@...r.kernel.org, guido@...ntalancia.com, paulus@...ba.org, linux-hams@...r.kernel.org, hans@...ac.ele.tue.nl Subject: Re: [PATCH] NET: Fix locking issues in PPP, 6pack, mkiss and strip line disciplines. On Sun, 12 Jul 2009 21:07:30 -0700 (PDT) David Miller <davem@...emloft.net> wrote: > From: Alan Cox <alan@...rguk.ukuu.org.uk> > Date: Sun, 12 Jul 2009 23:48:54 +0100 > > >> The issue was, that the locking code in mkiss was assuming it was only > >> ever being called in process or bh context. Fixed by converting the > >> involved locking code to use irq-safe locks. > > > > Which historically of course was correct until the networking layer > > changed behaviour some years ago. > > Networking layer? Surely you mean the TTY layer or USB because I > don't see anything networking in his traces :-) No I mean the network layer. Historically it went network bh transmit packet ldisc layer tty write method and lots of code assumed that. Today the network bits get kicked off at IRQ level. Most tty stuff now handles it, some of it has been broken with ppp for ages but its been so long its hardly a regression any more and its dumb stuff like jtag consoles and i2c serial ports that break. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists