netdev - Re: [PATCH 0/4] inet6: minor cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090721.125745.210846096.davem@davemloft.net>
Date:	Tue, 21 Jul 2009 12:57:45 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	gerrit@....abdn.ac.uk
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 0/4] inet6: minor cleanups

From: Gerrit Renker <gerrit@....abdn.ac.uk>
Date: Sun, 19 Jul 2009 20:23:35 +0200

> This is a small set of minor-cleanup patches, found while
> studying the tclass code.
> 
> Patch #1: Unifies return convention of datagram_send_ctl().

OK.

> Patch #2: Consolidates cmsg code for Traffic Class / Hop Limit.

You delete the 'addr_type' variable but that's rediculious.

The name of the variable describes what is held in it, now
that value gets stored in 'val' which makes the code harder
to read and understand.

I'm not applying this, it's noise, and on top of that it's
bad noise and makes the code worse.

> Patch #3: Simplifies assignments from u8 to int (no conversion).

OK.

> Patch #4: Finds that RT_TOS() redefines IPTOS_TOS().

This macro probably exists so that if the ipv4 route cache entry TOS
representation changes compared to IPTOS_TOS(), we would simply have
to change the definition of this macro.

Just because they happen to be the same now is no reason to kill off
this macro I think.

I'm not applying this either.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html