netdev - Re: PATCH: veth: Zero timestamp in xmit path.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090721.125155.168882282.davem@davemloft.net>
Date:	Tue, 21 Jul 2009 12:51:55 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	greearb@...delatech.com
Cc:	netdev@...r.kernel.org
Subject: Re: PATCH: veth: Zero timestamp in xmit path.

From: Ben Greear <greearb@...delatech.com>
Date: Tue, 21 Jul 2009 12:46:55 -0700

> This patch zero's the timestamp before handing the packet to
> the peer interface.  This lets the peer recalculate the rx timestamp
> if it cares about timestamps.
> 
> The patch is against net-next, compile tested there.  Similar patch
> was
> functionally tested against 2.6.31-rc3.
> 
> 
> Signed-Off-By:  Ben Greear<greearb@...delatech.com>

Oh, where to begin... sigh...

The "off" and "by" in "Signed-off-by" is not capitalized.

There should not be two spaces after the Signed-off-by colon, there
should be only one.

There should be a space between your name and your <> enclosed email
address.

> @@ -171,6 +171,7 @@ static int veth_xmit(struct sk_buff *skb, struct
> net_device *dev)

Your email client corrupted the patch by splitting up this line.

This is all just being sloppy, and it shows a lack of care put
into your submission.

Nevertheless I'm a sucker and I fixed this all up and applied your
patch.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html