netdev - Re: PATCH: veth: Zero timestamp in xmit path.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090721.130542.158855009.davem@davemloft.net>
Date:	Tue, 21 Jul 2009 13:05:42 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	greearb@...delatech.com
Cc:	netdev@...r.kernel.org
Subject: Re: PATCH: veth: Zero timestamp in xmit path.

From: Ben Greear <greearb@...delatech.com>
Date: Tue, 21 Jul 2009 13:02:02 -0700

> On 07/21/2009 12:51 PM, David Miller wrote:
>> From: Ben Greear<greearb@...delatech.com>
>> Date: Tue, 21 Jul 2009 12:46:55 -0700
>>
>>> Signed-Off-By:  Ben Greear<greearb@...delatech.com>
>>
>> Oh, where to begin... sigh...
>>
>> The "off" and "by" in "Signed-off-by" is not capitalized.
>>
>> There should not be two spaces after the Signed-off-by colon, there
>> should be only one.
>>
>> There should be a space between your name and your<>  enclosed email
>> address.
> 
> I had no idea that was so important.

If you aren't even going to check over such easy and trivial visual
matters such as this, one can only imagine how much care has been put
into the change itself.

It shows how much you care about how your work and submissions look to
other people.

It's as much an issue of what it shows about the submitter's overall
mentality as it is an issue of "does it matter" or how important it is
to get the signoff syntax correct.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html