netdev - Re: [PATCH] igb/e1000e/e1000/e100: make wol usable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090723.110647.228266156.davem@davemloft.net>
Date:	Thu, 23 Jul 2009 11:06:47 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	peter.p.waskiewicz.jr@...el.com
Cc:	andy@...yhouse.net, alexander.duyck@...il.com,
	john.ronciak@...el.com, netdev@...r.kernel.org,
	jeffrey.t.kirsher@...el.com, jesse.brandeburg@...el.com,
	bruce.w.allan@...el.com, stable@...nel.org
Subject: Re: [PATCH] igb/e1000e/e1000/e100: make wol usable

From: "Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>
Date: Wed, 22 Jul 2009 16:43:03 -0700 (Pacific Daylight Time)

> On Wed, 22 Jul 2009, Andy Gospodarek wrote:
> 
>> [PATCH] ixgbe: remove unnecessary call to device_init_wakeup
>> 
>> Calls to device_init_wakeup should not be necessary in drivers that use
>> device_set_wakeup_enable since pci_pm_init will set the can_wakeup flag
>> for the device when initialized.
>> 
>> I can't test this since I don't have any of the 82599 KX4 interfaces
>> (the only ones capable of WOL), but I did instrument ixgbe_probe and
>> know that can_wakeup=1 when device_init_wakeup is removed.
>> 
>> Signed-off-by: Andy Gospodarek <andy@...yhouse.net>
 ...
> Works just fine on two different 82599 mezz cards that support WoL.  
> Thanks Andy for finding and fixing.
> 
> Acked-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html