netdev - Re: [RFC] [PATCH] Don't run __qdisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090724145407.GA25861@gondor.apana.org.au>
Date:	Fri, 24 Jul 2009 22:54:07 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Eric Dumazet <dada1@...mosbay.com>
Cc:	Krishna Kumar <krkumar2@...ibm.com>, davem@...emloft.net,
	netdev@...r.kernel.org, Jarek Poplawski <jarkao2@...il.com>
Subject: Re: [RFC] [PATCH] Don't run __qdisc_run() on a stopped TX queue

On Fri, Jul 24, 2009 at 02:46:06PM +0200, Eric Dumazet wrote:
> Krishna Kumar a écrit :
> > From: Krishna Kumar <krkumar2@...ibm.com>
> > diff -ruNp org/net/sched/sch_generic.c new/net/sched/sch_generic.c
> > --- org/net/sched/sch_generic.c	2009-05-25 07:48:07.000000000 +0530
> > +++ new/net/sched/sch_generic.c	2009-07-20 13:09:18.000000000 +0530
> > @@ -56,12 +56,8 @@ static inline struct sk_buff *dequeue_sk
> >  	struct sk_buff *skb = q->gso_skb;
> >  
> >  	if (unlikely(skb)) {
> > -		struct net_device *dev = qdisc_dev(q);
> > -		struct netdev_queue *txq;
> > -
> >  		/* check the reason of requeuing without tx lock first */
> > -		txq = netdev_get_tx_queue(dev, skb_get_queue_mapping(skb));
> > -		if (!netif_tx_queue_stopped(txq) && !netif_tx_queue_frozen(txq))
> > +		if (!netif_tx_queue_frozen(q->dev_queue))
> >  			q->gso_skb = NULL;
> 
> This part might be a separate patch...
> 
> Are we sure these are equivalent ?

I think the only thing that can change this is act_skbedit.  But
really any queue that changes the skb queue mapping should physically
move the packet to that qdisc.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html