netdev - Re: net-next-2.6 phonet causes build error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090727.083011.208767018.davem@davemloft.net>
Date:	Mon, 27 Jul 2009 08:30:11 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	marcel@...tmann.org
Cc:	remi.denis-courmont@...ia.com, netdev@...r.kernel.org
Subject: Re: net-next-2.6 phonet causes build error

From: Marcel Holtmann <marcel@...tmann.org>
Date: Mon, 27 Jul 2009 17:18:29 +0200

> Hi Dave,
> 
>> >> net/phonet/pn_dev.c: In function ‘phonet_init_net’:
>> >> net/phonet/pn_dev.c:221: error: implicit declaration of function
>> >> ‘proc_net_fops_create’
>> >> net/phonet/pn_dev.c: In function ‘phonet_exit_net’:
>> >> net/phonet/pn_dev.c:242: error: implicit declaration of function
>> >> ‘proc_net_remove’
>> > 
>> > Oops. This makes me wonder why I did not get that one here on my test 
>> > builds???
>> 
>> Because the headers on your platform with your configuration end up
>> including linux/proc_fs.h indirectly.
> 
> this and similar automatic includes on x86 are still a problem. I always
> try to compile test with a PPC based system, but even that architecture
> has a lot of indirect includes. I would be happy if we could get rid of
> these for x86 systems, but that seems a little bit wishful thinking.

I always do an allmodconfig build on sparc64 before pushing anything
out to my trees so I'm surprised I didn't hit this one.