netdev - Re: [PATCH] net: shrink net_device by #ifdef-ing protocol-specific members

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1248711781.10463.108.camel@Joe-Laptop.home>
Date:	Mon, 27 Jul 2009 09:23:01 -0700
From:	Joe Perches <joe@...ches.com>
To:	David Miller <davem@...emloft.net>
Cc:	lgrijincu@...acom.com, netdev@...r.kernel.org,
	eric.dumazet@...il.com
Subject: Re: [PATCH] net: shrink net_device by #ifdef-ing protocol-specific
 members

On Mon, 2009-07-27 at 08:26 -0700, David Miller wrote:
> From: Lucian Adrian Grijincu <lgrijincu@...acom.com>
> Date: Mon, 27 Jul 2009 18:09:08 +0300
> > Some members of net_device are used only by some protocols.
> > If those protocols are not compiled (as modules or linked in) they
> > should not take up space in the structure.
> This benefits, at best, %0.000000001 of users of the Linux kernel,
> because every distribution is going to turn on every single option.

I think the cost of maintaining this is small and the
percentage of users that benefit underestimated.

It does help handsets a trivial amount, which are unlikely
to ever enable decnet or econet.

> If you want to shrink structures, find ways to eliminate or
> shrink structure members in all cases.

Good advice.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html