netdev - Re: [PATCH] net: shrink net_device by #ifdef-ing protocol-specific members

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090727.092712.84381944.davem@davemloft.net>
Date:	Mon, 27 Jul 2009 09:27:12 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	joe@...ches.com
Cc:	lgrijincu@...acom.com, netdev@...r.kernel.org,
	eric.dumazet@...il.com
Subject: Re: [PATCH] net: shrink net_device by #ifdef-ing protocol-specific
 members

From: Joe Perches <joe@...ches.com>
Date: Mon, 27 Jul 2009 09:23:01 -0700

> On Mon, 2009-07-27 at 08:26 -0700, David Miller wrote:
>> From: Lucian Adrian Grijincu <lgrijincu@...acom.com>
>> Date: Mon, 27 Jul 2009 18:09:08 +0300
>> > Some members of net_device are used only by some protocols.
>> > If those protocols are not compiled (as modules or linked in) they
>> > should not take up space in the structure.
>> This benefits, at best, %0.000000001 of users of the Linux kernel,
>> because every distribution is going to turn on every single option.
> 
> I think the cost of maintaining this is small and the
> percentage of users that benefit underestimated.

Prove it.

Prove that it helps enough to maintain this ifdef abortion in our
header files.

It only gives the false sense of satisfation that we're making our
datastructures less bloated.  We're not, and in fact they keep getting
larger, and if we add these ifdefs the new excuse for bloat will be
"but it gets compiled out on embedded et al.  builds that don't use
this or that feature."

Putting this crap in is just a big smoke screen which gives a
disincentive for making real improvements in this area.

If I thought this was worthwhile I would have done it 10 years ago.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html