netdev - Re: [PATCH ver2] Avoid enqueuing skb for default qdiscs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090806.134126.58668200.davem@davemloft.net>
Date:	Thu, 06 Aug 2009 13:41:26 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	krkumar2@...ibm.com
Cc:	jarkao2@...il.com, netdev@...r.kernel.org,
	herbert@...dor.apana.org.au, kaber@...sh.net
Subject: Re: [PATCH ver2] Avoid enqueuing skb for default qdiscs

From: Krishna Kumar <krkumar2@...ibm.com>
Date: Thu, 06 Aug 2009 17:14:21 +0530

> -
>  static inline int dev_requeue_skb(struct sk_buff *skb, struct Qdisc *q)
>  {
>  	q->gso_skb = skb;
>  	q->qstats.requeues++;
> +	q->q.qlen++;	/* it's still part of the queue */
>  	__netif_schedule(q);
>  
>  	return 0;

I'm dubious about this new qlen accounting scheme, does it handle
the non-bypass case properly?  Can you explain how it works
exactly?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html