netdev - Re: [PATCH ver2] Avoid enqueuing skb for default qdiscs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <OF7BAC954C.BF5F5187-ON6525760B.00102708-6525760B.0010A0A6@in.ibm.com>
Date:	Fri, 7 Aug 2009 08:31:37 +0530
From:	Krishna Kumar2 <krkumar2@...ibm.com>
To:	Stephen Hemminger <shemminger@...tta.com>
Cc:	davem@...emloft.net, herbert@...dor.apana.org.au,
	Jarek Poplawski <jarkao2@...il.com>, kaber@...sh.net,
	netdev@...r.kernel.org
Subject: Re: [PATCH ver2] Avoid enqueuing skb for default qdiscs

Hi Stephen,

Stephen Hemminger <shemminger@...tta.com> wrote on 08/07/2009 02:19:46 AM:

> > +static inline int qdisc_qlen(struct Qdisc *q)
> > +{
> > +   return q->q.qlen;
> > +}
> > +
>
> Why?
> This kind of oneline accessor decreases the code clarity.

qdisc_qlen() was previously defined in sch_generic.c. I moved it
to the header file so that it could be accessed in dev.c (where
there is no code using q.qlen), so it is not new code.

Thanks,

- KK

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html