netdev - Re: [PATCH ver2] Avoid enqueuing skb for default qdiscs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090806.200857.172982468.davem@davemloft.net>
Date:	Thu, 06 Aug 2009 20:08:57 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	krkumar2@...ibm.com
Cc:	herbert@...dor.apana.org.au, jarkao2@...il.com, kaber@...sh.net,
	netdev@...r.kernel.org
Subject: Re: [PATCH ver2] Avoid enqueuing skb for default qdiscs

From: Krishna Kumar2 <krkumar2@...ibm.com>
Date: Fri, 7 Aug 2009 08:26:04 +0530

> David Miller <davem@...emloft.net> wrote on 08/07/2009 02:11:26 AM:
> 
>> I'm dubious about this new qlen accounting scheme, does it handle
>> the non-bypass case properly?  Can you explain how it works
>> exactly?
> 
> Adding one to qlen will handle non-bypass correctly. On the next
> non-bypass (or a bypass) xmit, dequeue_skb will remove gso_skb and
> decrement the counter. If no more xmits are done, qdisc_reset will
> also fix it. I got this idea by extending one of Jarek's patches:

Aha, I see.  Thanks for the explanation.

Ok, I'll let this rip... let's see what falls out of it :-)
Will apply this to net-next-2.6 right now.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html